Subject: Re: [PATCH] usbnet: Do not implement ethtool get_link() if link state is unknown

From: Ben Hutchings <[email-masked]>
Date: Wed, 04 Nov 2009 03:20:00 +0000

On Tue, 2009-11-03 at 02:04 -0800, David Miller wrote:
> From: David Brownell <[email-masked]>
> Date: Tue, 3 Nov 2009 02:41:27 -0700
> 
> > On Tuesday 03 November 2009, David Miller wrote:
> >> All kidding aside, I think the alternative is for the USB network
> >> driver to call ethtool_op_get_link() if it cannot determine the
> >> link state in hardware.
> > 
> > There's usbnet_get_link() which does just that.  But
> > there may be some ancient debris confusing things.
> 
> It's perfect, and Ben's patch is completely unnecessary.

I don't see how it's 'perfect' since it reports the link as up where it
is really unknown.  Still, this is a fairly minor bug.

Ben.

-- 
Ben Hutchings
The generation of random numbers is too important to be left to chance.
                                                            - Robert Coveyou