Subject: Re: [PATCH 4/5] bnx2: Read firmware version from VPD.

From: "Michael Chan" <[email-masked]>
Date: Thu, 3 Dec 2009 13:43:48 -0800

On Thu, 2009-12-03 at 12:17 -0800, Ben Hutchings wrote:
> > +     for (i = 0; i < 128; i += 4) {
> > +             data[i] = data[i + 131];
> > +             data[i + 1] = data[i + 130];
> > +             data[i + 2] = data[i + 129];
> > +             data[i + 3] = data[i + 128];
> > +     }
> 
> Is this correct for both big-endian and little-endian architectures?

Yes, the nvram function returns data in a byte-stream that is the same
in little or big endian.

> Perhaps these VPD tag values should go in pci_regs.h.

How about we do this later and convert other drivers at the same time?

I will send out a fixup patch shortly incorporating all your other
suggestions.  Thanks.