Subject: Re: [net-2.6 PATCH 1/3] ixgbe: Fix compiler warning about variable being used uninitialized

From: Peter P Waskiewicz Jr <[email-masked]>
Date: Sun, 13 Dec 2009 20:55:22 -0800

On Sun, 2009-12-13 at 19:20 -0800, David Miller wrote:
> From: Jeff Kirsher <[email-masked]>
> Date: Fri, 11 Dec 2009 23:51:23 -0800
> 
> > From: PJ Waskiewicz <[email-masked]>
> > 
> > tc is still throwing a warning that is could be used
> > uninitialized.  This fixes it.
> > 
> > Signed-off-by: Peter P Waskiewicz Jr <[email-masked]>
> > Signed-off-by: Jeff Kirsher <[email-masked]>
> 
> It's warning because it absolutely can be used uninitialized.
> 
> The two code blocks only handle two chip variants.  Why not
> make what's happening here explicit by using a switch
> statement and having a 'default' case?

That I can do, and makes more sense.  I'll respin the patch.

Thanks Dave,
-PJ