From: Marcel Holtmann <marcel@holtmann•org>
To: Mike Frysinger <vapier@gentoo•org>
Cc: netdev@vger•kernel.org, "David S. Miller" <davem@davemloft•net>,
uclinux-dist-devel@blackfin•uclinux.org,
Michael Hennerich <michael.hennerich@analog•com>
Subject: Re: [PATCH] wireless: adf702x: new driver for ADF7020/21 parts
Date: Mon, 21 Dec 2009 19:05:02 -0800 [thread overview]
Message-ID: <1261451102.4041.170.camel@localhost.localdomain> (raw)
In-Reply-To: <1261447929-17106-1-git-send-email-vapier@gentoo.org>
Hi Mike,
> This is a driver for Analog Devices series of ADF702x Narrow-Band
> Short-Range Radio Transceiver chipsets, including the ADF7021 and
> the ADF7025. This Ethernet like driver implements a custom
> software PHY.
while it might be a little bit confusing, but the wireless directory
normally only contains Wireless LAN (aka 802.11 and alike) drivers.
If this implements some sort of Ethernet driver, then it might be better
to just put it under drivers/net/ to not intermix and confuse it with
actually 802.11 drivers.
> drivers/net/wireless/Kconfig | 11 +
> drivers/net/wireless/Makefile | 2 +
> drivers/net/wireless/adf702x.c | 788 ++++++++++++++++++++++++++++++++++++++++
> include/linux/spi/adf702x.h | 33 ++
> 4 files changed, 834 insertions(+), 0 deletions(-)
> create mode 100644 drivers/net/wireless/adf702x.c
> create mode 100644 include/linux/spi/adf702x.h
And why is the header file under SPI includes. It could be as easily in
the same directory as the driver *.c file itself. No reason to spread it
over the whole tree if nothing else includes it.
Regards
Marcel
next prev parent reply other threads:[~2009-12-22 3:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-22 2:12 [PATCH] wireless: adf702x: new driver for ADF7020/21 parts Mike Frysinger
2009-12-22 3:05 ` Marcel Holtmann [this message]
2009-12-22 10:38 ` Hennerich, Michael
2009-12-22 12:46 ` Marcel Holtmann
2009-12-22 12:56 ` Hennerich, Michael
2009-12-22 13:09 ` [Uclinux-dist-devel] " Mike Frysinger
2009-12-22 3:44 ` Ben Hutchings
2009-12-22 11:46 ` Hennerich, Michael
2009-12-22 16:02 ` Ben Hutchings
2010-01-19 7:37 ` [Uclinux-dist-devel] " Mike Frysinger
2010-01-19 7:39 ` [PATCH v2] " Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1261451102.4041.170.camel@localhost.localdomain \
--to=marcel@holtmann$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=michael.hennerich@analog$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=uclinux-dist-devel@blackfin$(echo .)uclinux.org \
--cc=vapier@gentoo$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox