Subject: Re: [PATCH] be2net: Bug fix to support newer generation of BE ASIC

From: Ben Hutchings <[email-masked]>
Date: Thu, 28 Jan 2010 22:40:29 +0000

On Thu, 2010-01-28 at 13:26 +0530, Ajit Khaparde wrote:
> Bug fix in be2net for newer generation of BladeEngine ASIC.
[...]
> @@ -2162,6 +2168,7 @@ static int be_stats_init(struct be_adapter *adapter)
>  	cmd->va = pci_alloc_consistent(adapter->pdev, cmd->size, &cmd->dma);
>  	if (cmd->va == NULL)
>  		return -1;
> +	memset(cmd->va, cmd->size, 0);
>  	return 0;
>  }
>  
[...]

I don't think this does what you think it does.

Also, you should either send this patch to [email-masked], or NAK the
addition of PCI ids for BladeEngine 3 in 2.6.32.7.

Ben.

-- 
Ben Hutchings
You can't have everything.  Where would you put it?