Subject: Re: [net-next-2.6 PATCH 1/7] xfrm: introduce basic mark infrastructure

From: jamal <[email-masked]>
Date: Mon, 15 Feb 2010 12:00:35 -0500

On Mon, 2010-02-15 at 16:42 +0100, Patrick McHardy wrote:

> This doesn't look right. A mark value of 0 with a mask of ~0 won't
> be properly dumped. I think this should check for (m->m | m->v).
> 

Good point, thanks. I will make that change;

Rest of patches look reasonable?

cheers,
jamal