From: <gregkh@suse•de>
To: u.kleine-koenig@pengutronix•de, 12o3l@tiscali•nl,
akpm@linux-foundation•org, gregkh@suse•de,
netdev@vger•kernel.org, rmk+kernel@arm•linux.org.uk
Subject: patch net-move-am79c961-s-probe-function-to-.devinit.text.patch added to gregkh-2.6 tree
Date: Wed, 17 Feb 2010 13:15:00 -0800 [thread overview]
Message-ID: <12664413002764@kroah.org> (raw)
In-Reply-To: <1265313417-5568-9-git-send-email-u.kleine-koenig@pengutronix.de>
This is a note to let you know that I've just added the patch titled
Subject: net: move am79c961's probe function to .devinit.text
to my gregkh-2.6 tree. Its filename is
net-move-am79c961-s-probe-function-to-.devinit.text.patch
This tree can be found at
http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/patches/
From u.kleine-koenig@pengutronix•de Wed Feb 17 12:45:57 2010
From: Uwe Kleine-König <u.kleine-koenig@pengutronix•de>
Date: Thu, 4 Feb 2010 20:56:57 +0100
Subject: net: move am79c961's probe function to .devinit.text
To: Greg KH <gregkh@suse•de>
Cc: Roel Kluin <12o3l@tiscali•nl>, Russell King <rmk+kernel@arm•linux.org.uk>, netdev@vger•kernel.org, Andrew Morton <akpm@linux-foundation•org>
Message-ID: <1265313417-5568-9-git-send-email-u.kleine-koenig@pengutronix•de>
From: Uwe Kleine-König <u.kleine-koenig@pengutronix•de>
A pointer to am79c961_probe is passed to the core via
platform_driver_register and so the function must not disappear when the
.init sections are discarded. Otherwise (if also having HOTPLUG=y)
unbinding and binding a device to the driver via sysfs will result in an
oops as does a device being registered late.
An alternative to this patch is using platform_driver_probe instead of
platform_driver_register plus removing the pointer to the probe function
from the struct platform_driver.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix•de>
Cc: Roel Kluin <12o3l@tiscali•nl>
Cc: Russell King <rmk+kernel@arm•linux.org.uk>
Cc: <netdev@vger•kernel.org>
Cc: Andrew Morton <akpm@linux-foundation•org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse•de>
---
drivers/net/arm/am79c961a.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/net/arm/am79c961a.c
+++ b/drivers/net/arm/am79c961a.c
@@ -680,7 +680,7 @@ static const struct net_device_ops am79c
#endif
};
-static int __init am79c961_probe(struct platform_device *pdev)
+static int __devinit am79c961_probe(struct platform_device *pdev)
{
struct resource *res;
struct net_device *dev;
prev parent reply other threads:[~2010-02-17 21:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20100203150850.GA28815@kroah.com>
2010-02-04 19:56 ` [PATCH 9/9] net: move am79c961's probe function to .devinit.text Uwe Kleine-König
2010-02-04 20:05 ` David Miller
2010-02-04 20:06 ` Uwe Kleine-König
2010-02-12 20:11 ` David Miller
2010-02-17 20:46 ` Greg KH
2010-02-17 21:15 ` gregkh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12664413002764@kroah.org \
--to=gregkh@suse$(echo .)de \
--cc=12o3l@tiscali$(echo .)nl \
--cc=akpm@linux-foundation$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=rmk+kernel@arm$(echo .)linux.org.uk \
--cc=u.kleine-koenig@pengutronix$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox