From: Vasu Dev <vasu.dev@linux•intel.com>
To: David Miller <davem@davemloft•net>, eric.dumazet@gmail•com
Cc: jeffrey.t.kirsher@intel•com, netdev@vger•kernel.org,
gospo@redhat•com, vasu.dev@intel•com
Subject: Re: [net-next-2.6 PATCH 1/3] vlan: adds vlan_dev_select_queue
Date: Wed, 17 Feb 2010 14:40:41 -0800 [thread overview]
Message-ID: <1266446441.1891.96.camel@vi2.jf.intel.com> (raw)
In-Reply-To: <20100217.134330.48386140.davem@davemloft.net>
On Wed, 2010-02-17 at 13:43 -0800, David Miller wrote:
> From: Eric Dumazet <eric.dumazet@gmail•com>
> Date: Wed, 17 Feb 2010 14:51:15 +0100
>
> > This is a bit dangerous and deserves a self contained patch IMHO.
> >
OK, I'll create separate patch for this.
> > I would add for example a
> > BUG_ON(vlandev->real_num_tx_queues > vlandev->num_tx_queues)
> >
I'll add this.
> > ------------------
> >
> > For performance reason, we could avoid calling vlan_dev_select_queue()
> > for real devices without ndo_select_queue() handler, this would need to
> > mirror vlan_netdev_ops & vlan_netdev_accel_ops.
> >
This means vlan_netdev_ops & vlan_netdev_accel_ops not to be const
anymore so that vlan_dev_select_queue() could be initialized to vlan ops
based on real dev ndo_select_queue() present or not, should be okay to
be not const anymore. I'll update patch as suggested.
> > It would also make vlan_dev_select_queue shorter and not duplicates
> > internals of net/dev/core.c :
> >
Good reasons.
> > static u16 vlan_dev_select_queue(struct net_device *dev, struct sk_buff
> > *skb)
> > {
> > struct net_device *rdev = vlan_dev_info(dev)->real_dev;
> > const struct net_device_ops *ops = rdev->netdev_ops;
> >
> > return ops->ndo_select_queue(rdev, skb);
> > }
> >
> >
>
> Jeff, please resubmit this patch set after addressing
> Eric's feedback.
>
I'm updating patches per Eric's feedback to have Jeff resubmit these
patches.
Vasu
next prev parent reply other threads:[~2010-02-17 22:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-17 12:36 [net-next-2.6 PATCH 1/3] vlan: adds vlan_dev_select_queue Jeff Kirsher
2010-02-17 12:36 ` [net-next-2.6 PATCH 2/3] ixgbe: fix real_num_tx_queues update issue Jeff Kirsher
2010-02-17 12:36 ` [net-next-2.6 PATCH 3/3] net: consolidate netif_needs_gso() checks Jeff Kirsher
2010-02-17 13:51 ` [net-next-2.6 PATCH 1/3] vlan: adds vlan_dev_select_queue Eric Dumazet
2010-02-17 21:43 ` David Miller
2010-02-17 22:40 ` Vasu Dev [this message]
2010-02-18 7:37 ` Eric Dumazet
2010-02-19 1:12 ` Vasu Dev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1266446441.1891.96.camel@vi2.jf.intel.com \
--to=vasu.dev@linux$(echo .)intel.com \
--cc=davem@davemloft$(echo .)net \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=gospo@redhat$(echo .)com \
--cc=jeffrey.t.kirsher@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=vasu.dev@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox