Subject: Re: [RFC PATCH net-2.6] net/ethtool: add multiple queue support to {get,set}_ringparams

From: Ben Hutchings <[email-masked]>
Date: Sun, 14 Mar 2010 04:21:57 +0000

On Sun, 2010-03-14 at 07:13 +0530, Ajit Khaparde wrote:
> With network devices and hence device drivers supporting
> multiple Tx and Rx rings, currently there is no way for
> ethtool to specify which Tx/Rx ring the user wants to get/set.
> This patch enhances the {get,set}_ringparams by allowing
> the user to specify the Tx/Rx ring id of interest.
> Please review.
[...]

So long as queue selection is done using a hash of the flow parameters,
there is no sense in setting different sizes for different queues.  If
drivers use additional queues that are not selected in this way and
which may require different sizes, that information also needs to be
exposed through ethtool (and perhaps to the networking core).

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.