Subject: Re: [Patch] netconsole: do not depend on experimental

From: Matt Mackall <[email-masked]>
Date: Mon, 22 Mar 2010 17:17:43 -0500

On Mon, 2010-03-22 at 08:59 -0400, Neil Horman wrote:
> On Mon, Mar 22, 2010 at 05:59:23AM -0400, Amerigo Wang wrote:
> > 
> > Nowadays, most distributions enable netconsole by default,
> > including RHEL, Fedora, Debian, Arch, Opensuse. And
> > we don't have any bug reports about it. So I think there
> > is no need to mark it as experimental any more.
> > 
> > Cc: David S. Miller <[email-masked]>
> > Signed-off-by: WANG Cong <[email-masked]>
> > 
> > ---
> > diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> > index 0ba5b8e..e3d6c52 100644
> > --- a/drivers/net/Kconfig
> > +++ b/drivers/net/Kconfig
> > @@ -3252,15 +3252,14 @@ config NET_FC
> >  	  "SCSI generic support".
> >  
> >  config NETCONSOLE
> > -	tristate "Network console logging support (EXPERIMENTAL)"
> > -	depends on EXPERIMENTAL
> > +	tristate "Network console logging support"
> >  	---help---
> >  	If you want to log kernel messages over the network, enable this.
> >  	See <file:Documentation/networking/netconsole.txt> for details.
> >  
> >  config NETCONSOLE_DYNAMIC
> > -	bool "Dynamic reconfiguration of logging targets (EXPERIMENTAL)"
> > -	depends on NETCONSOLE && SYSFS && EXPERIMENTAL
> > +	bool "Dynamic reconfiguration of logging targets"
> > +	depends on NETCONSOLE && SYSFS
> >  	select CONFIGFS_FS
> >  	help
> >  	  This option enables the ability to dynamically reconfigure target
> > --
> 
> Seems reasonable.  Netconsole seems pretty mature.
> 
> Acked-by: Neil Horman <[email-masked]>

Yeah, I'd forgotten that flag was even there.

Acked-by: Matt Mackall <[email-masked]>

-- 
http://selenic.com : development and support for Mercurial and Linux