From: Ben Hutchings <bhutchings-s/n/eUQHGBpZroRs9YW3xA@public•gmane.org>
To: Elina Pasheva
<epasheva-ywE8TTl5eJHWpu6QEFMNjNBPR1lH4CV8@public•gmane.org>
Cc: davem-fT/PcQaiUtIeIZ0/mPfg9Q@public•gmane.org,
Rory Filer
<rfiler-ywE8TTl5eJHWpu6QEFMNjNBPR1lH4CV8@public•gmane.org>,
"dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public•gmane.org"
<dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public•gmane.org>,
"linux-usb-u79uwXL29TY76Z2rM5mHXA@public•gmane.org"
<linux-usb-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>,
"netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org"
<netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>
Subject: RE: re-submit2 [ANNOUNCEMENT] NET: usb: sierra_net.c driver
Date: Thu, 01 Apr 2010 00:26:09 +0100 [thread overview]
Message-ID: <1270077969.8653.491.camel@localhost> (raw)
In-Reply-To: <1270069108.6053.5.camel@Linuxdev3>
On Wed, 2010-03-31 at 13:58 -0700, Elina Pasheva wrote:
> On Tue, 2010-03-30 at 23:21 -0700, Rory Filer wrote:
> > -----Original Message-----
> > > >
> > > > Applied, thanks.
> > >
> > > Nevermind, reverted, it doesn't even build.
> > >
> > > drivers/net/usb/sierra_net.c: In function 'check_ethip_packet':
> > > drivers/net/usb/sierra_net.c:221:3: error: implicit declaration of
> > > function 'deverr'
> > >
> > > Really, this should never ever happen, and there is simply
> > > no excuse at all for this.
> >
> > Well actually there is an excuse, but I'm sure you don't want to
> > know what it is.
>
> The patch was posted saying it had only been tested on 2.6.33.1.
> There was failure-to-build and boot problems beyond our control with 2.6.34-rc2.
> Now that 2.6.34-rc3 is available (and we are able to build and boot on our Ubuntu platform)
> I will modify the driver to reflect the fact that deverr is no longer in existence
> and is replaced by another function. I will submit the modified driver tested on 2.6.34-rc3 shortly.
You should be sending patches based on David Miller's net-next-2.6 or
net-2.6 git repository, where he will be applying them. As this is a
new driver I assume it can go into net-2.6.
> Perhaps we should have waited until the build problem was fixed.
Or come up with a fix yourself.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public•gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2010-03-31 23:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-29 20:13 re-submit2 [ANNOUNCEMENT] NET: usb: sierra_net.c driver Elina Pasheva
2010-03-31 6:09 ` David Miller
[not found] ` <20100330.230932.244208287.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2010-03-31 6:10 ` David Miller
[not found] ` <20100330.231051.113008279.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2010-03-31 6:21 ` Rory Filer
[not found] ` <8F90F944E50427428C60E12A34A309D22FC800D825-3qf8vkpM5jTbmvMHnzRVpW3Pdy6AhKVLXbPIYa3/oNjDOqzlkpFKJg@public.gmane.org>
2010-03-31 20:58 ` Elina Pasheva
2010-03-31 23:26 ` Ben Hutchings [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1270077969.8653.491.camel@localhost \
--to=bhutchings-s/n/euqhgbpzrors9yw3xa@public$(echo .)gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public$(echo .)gmane.org \
--cc=dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public$(echo .)gmane.org \
--cc=epasheva-ywE8TTl5eJHWpu6QEFMNjNBPR1lH4CV8@public$(echo .)gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=rfiler-ywE8TTl5eJHWpu6QEFMNjNBPR1lH4CV8@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox