From: "Michael Chan" <mchan@broadcom•com>
To: "David Miller" <davem@davemloft•net>
Cc: "adetsch@br•ibm.com" <adetsch@br•ibm.com>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"Matthew Carlson" <mcarlson@broadcom•com>
Subject: Re: [PATCH v2] tg3: Fix INTx fallback when MSI fails
Date: Mon, 26 Apr 2010 11:01:21 -0700 [thread overview]
Message-ID: <1272304881.9950.19.camel@HP1> (raw)
In-Reply-To: <20100426.111017.189698604.davem@davemloft.net>
On Mon, 2010-04-26 at 11:10 -0700, David Miller wrote:
> From: Andre Detsch <adetsch@br•ibm.com>
> Date: Mon, 26 Apr 2010 14:27:07 -0300
>
> > tg3: Fix INTx fallback when MSI fails
> >
> > MSI setup changes the value of irq_vec in struct tg3 *tp.
> > This attribute must be taken into account and restored before
> > we try to do a new request_irq for INTx fallback.
> >
> > In powerpc, the original code was leading to an EINVAL return within
> > request_irq, because the driver was trying to use the disabled MSI
> > virtual irq number instead of tp->pdev->irq.
> >
> > Signed-off-by: Andre Detsch <adetsch@br•ibm.com>
>
> Broadcom folks, I've already asked you to review Andre's original patch.
>
> If you can't be bothered to look at and ACK/NACK a simple fix like
> this for 10 days, then I'm just going to apply Andre's patch as-is
> since it looks right to me.
>
> If the idea was to bundle this up into a set of 15 patches you guys
> already have ready to bomb at me, I absolutely do not want you guys to
> operate that way. It doesn't work. You should be able to ACK a
> simple patch like this as soon as possible so it can be integrated
> upstream in the most expediant manner possible.
>
> Thanks.
>
Sorry, Matt just got back from vacation. I discussed with Andre earlier
today to come up with the new v2 patch. So this patch has my:
Acked-by: Michael Chan <mchan@broadcom•com>
next prev parent reply other threads:[~2010-04-26 18:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-16 13:15 [PATCH] tg3: Fix INTx fallback when MSI fails Andre Detsch
2010-04-21 23:17 ` David Miller
2010-04-26 17:27 ` [PATCH v2] " Andre Detsch
2010-04-26 18:10 ` David Miller
2010-04-26 18:01 ` Michael Chan [this message]
2010-04-26 18:15 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1272304881.9950.19.camel@HP1 \
--to=mchan@broadcom$(echo .)com \
--cc=adetsch@br$(echo .)ibm.com \
--cc=davem@davemloft$(echo .)net \
--cc=mcarlson@broadcom$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox