Subject: Re: tc: RTM_GETQDISC causes kernel OOPS

From: jamal <[email-masked]>
Date: Sat, 22 May 2010 08:31:49 -0400

On Sat, 2010-05-22 at 11:51 +0200, Patrick McHardy wrote:

> 
> We already use TCQ_F_BUILTIN in tc_qdisc_dump_ignore(), so I
> think it would be more consistent than checking for a handle
> to use it here as well.

Agree - it is more semantically correct..

I wonder though if it is better to do the check in tc_get_qdisc()
and tc_modify_qdisc()?

cheers,
jamal