Subject: Re: [PATCH v2] netfilter: Xtables: idletimer target implementation

From: Luciano Coelho <[email-masked]>
Date: Wed, 02 Jun 2010 22:05:53 +0300

On Wed, 2010-06-02 at 20:37 +0200, Coelho Luciano (Nokia-D/Helsinki)
wrote:
> On Wed, 2010-06-02 at 17:16 +0200, ext Jan Engelhardt wrote:
> > On Wednesday 2010-06-02 15:41, Luciano Coelho wrote:
> > 
> > >+static int __init idletimer_tg_init(void)
> > >+{
> > >+	int ret;
> > >+
> > >+	idletimer_tg_kobj = kobject_create_and_add("idletimer",
> > >+						   &THIS_MODULE->mkobj.kobj);
> > 
> > Isn't this going to oops when you compile this module as =y?
> 
> Damn, that's true. :(
> 
> I'll investigate how to fix this.

Would it be too hacky to force it to be a module (ie. add "depends on m"
in Kconfig)?

Besides /sys/module/xt_IDLETIMER and /sys/class/net, which we have
already discarded, I can't find any other place that would make sense to
add the idletimer in the kernel object hierarchy...

-- 
Cheers,
Luca.