From: Ben Hutchings <bhutchings@solarflare•com>
To: Randy Dunlap <randy.dunlap@oracle•com>
Cc: David Miller <davem@davemloft•net>,
netdev@vger•kernel.org, linux-net-drivers@solarflare•com,
sgruszka@redhat•com, amit.salecha@qlogic•com, amwang@redhat•com,
anirban.chakraborty@qlogic•com, dm@chelsio•com,
scofeldm@cisco•com, vkolluri@cisco•com, roprabhu@cisco•com,
e1000-devel@lists•sourceforge.net, buytenh@wantstofly•org,
gallatin@myri•com, brice@myri•com,
shemminger@linux-foundation•org, jgarzik@redhat•com
Subject: Re: [PATCH net-next-2.6 1/3] ethtool: Change ethtool_op_set_flags to validate flags
Date: Sat, 03 Jul 2010 20:21:24 +0100 [thread overview]
Message-ID: <1278184884.4878.559.camel@localhost> (raw)
In-Reply-To: <20100703120729.f2a2715b.randy.dunlap@oracle.com>
On Sat, 2010-07-03 at 12:07 -0700, Randy Dunlap wrote:
> On Fri, 02 Jul 2010 22:07:11 -0700 (PDT) David Miller wrote:
>
> > From: Randy Dunlap <randy.dunlap@oracle•com>
> > Date: Fri, 2 Jul 2010 09:55:14 -0700
> >
> > > On Wed, 30 Jun 2010 13:44:32 +0100 Ben Hutchings wrote:
> > >> @@ -457,7 +457,7 @@ int ethtool_op_set_tso(struct net_device *dev, u32 data);
> > >> u32 ethtool_op_get_ufo(struct net_device *dev);
> > >> int ethtool_op_set_ufo(struct net_device *dev, u32 data);
> > >> u32 ethtool_op_get_flags(struct net_device *dev);
> > >> -int ethtool_op_set_flags(struct net_device *dev, u32 data);
> > >> +int ethtool_op_set_flags(struct net_device *dev, u32 data, u32 supported);
> > >
> > > That one-line change is missing from linux-next-20100702, causing:
> > >
> > > drivers/infiniband/ulp/ipoib/ipoib_ethtool.c:157: warning: initialization from incompatible pointer type
> >
> > Strange, it's in net-next-2.6 for sure:
> >
> > davem@sunset:~/src/GIT/net-next-2.6$ egrep ethtool_op_set_flags include/linux/ethtool.h
> > int ethtool_op_set_flags(struct net_device *dev, u32 data, u32 supported);
>
> Yep, my bad.
>
> In include/linux/ethtool.h, struct ethtool_ops, field/member 'set_flags':
>
> int (*set_flags)(struct net_device *, u32);
>
> Does that need another u32 for 'supported'? This is where the linux-next
> warnings are coming from.
No, this is intentional. I just missed the users of
ethtool_op_set_flags() in drivers/infiniband. I'll send a patch for
those shortly.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2010-07-03 19:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-30 12:44 [PATCH net-next-2.6 1/3] ethtool: Change ethtool_op_set_flags to validate flags Ben Hutchings
2010-06-30 12:46 ` [PATCH net-next-2.6 2/3] netdev: Make ethtool_ops::set_flags() return -EINVAL for unsupported flags Ben Hutchings
2010-06-30 15:01 ` Eilon Greenstein
2010-06-30 21:10 ` David Miller
2010-06-30 12:47 ` [PATCH net-next-2.6 3/3] vmxnet3: Remove incorrect implementation of ethtool_ops::get_flags() Ben Hutchings
2010-06-30 15:44 ` [Pv-drivers] " Bhavesh Davda
2010-06-30 15:58 ` Ben Hutchings
2010-06-30 16:46 ` Bhavesh Davda
2010-06-30 21:10 ` David Miller
2010-06-30 21:10 ` [PATCH net-next-2.6 1/3] ethtool: Change ethtool_op_set_flags to validate flags David Miller
2010-07-02 16:55 ` Randy Dunlap
2010-07-03 5:07 ` David Miller
2010-07-03 19:07 ` Randy Dunlap
2010-07-03 19:21 ` Ben Hutchings [this message]
2010-07-03 19:41 ` [PATCH net-next-2.6] IB/{nes,ipoib}: Pass supported flags to ethtool_op_set_flags() Ben Hutchings
2010-07-03 20:08 ` Roland Dreier
2010-07-03 20:40 ` [PATCH net-next-2.6] IB/{nes, ipoib}: " Ben Hutchings
2010-07-04 18:48 ` [PATCH net-next-2.6] IB/{nes,ipoib}: " David Miller
2010-07-06 16:22 ` [PATCH net-next-2.6] IB/{nes, ipoib}: " Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1278184884.4878.559.camel@localhost \
--to=bhutchings@solarflare$(echo .)com \
--cc=amit.salecha@qlogic$(echo .)com \
--cc=amwang@redhat$(echo .)com \
--cc=anirban.chakraborty@qlogic$(echo .)com \
--cc=brice@myri$(echo .)com \
--cc=buytenh@wantstofly$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=dm@chelsio$(echo .)com \
--cc=e1000-devel@lists$(echo .)sourceforge.net \
--cc=gallatin@myri$(echo .)com \
--cc=jgarzik@redhat$(echo .)com \
--cc=linux-net-drivers@solarflare$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=randy.dunlap@oracle$(echo .)com \
--cc=roprabhu@cisco$(echo .)com \
--cc=scofeldm@cisco$(echo .)com \
--cc=sgruszka@redhat$(echo .)com \
--cc=shemminger@linux-foundation$(echo .)org \
--cc=vkolluri@cisco$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox