Subject: Re: [PATCH 1/2 -next] r8169: allocate with GFP_KERNEL flag when able to sleep

From: Ben Hutchings <[email-masked]>
Date: Sun, 26 Sep 2010 13:46:19 +0100

On Sun, 2010-09-26 at 08:09 +0200, Eric Dumazet wrote:
> Le dimanche 26 septembre 2010 à 00:33 +0100, Ben Hutchings a écrit :
> > On Sat, 2010-09-25 at 11:12 +0200, Eric Dumazet wrote:
> > [...]
> > > The r8169 current problem is its currently copying all incoming frames.
> > > I guess nobody cares or noticed the performance drop.
> > > (But commit c0cd884a is recent (2.6.34), this is not yet in
> > > production...)
> > 
> > Since that was a security fix it was backported to 2.6.32.12 and
> > probably most distribution kernels.  So yes it is in production.
> 
> Maybe in your company, not a single machine in mine ;)
> 
> Most linux servers in production run much older kernels.
> 
> rhel 5 -> 2.6.18
> debian 5 -> 2.6.26.x

Those both have the fix.  Look for CVE-2009-4537 in the changelog.

Ben.

-- 
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.