Subject: Re: [PATCH 1/2] Revert "ipv4: Make INET_LRO a bool instead of tristate."

From: Ben Hutchings <[email-masked]>
Date: Mon, 04 Oct 2010 04:54:55 +0100

On Sun, 2010-10-03 at 19:56 -0700, David Miller wrote:
> From: Ben Hutchings <[email-masked]>
> Date: Mon, 04 Oct 2010 02:37:42 +0100
> 
> > You made the change I want to revert in response to
> > <http://article.gmane.org/gmane.linux.kernel/825646>.  The real problem
> > with its configuration is actually that CONFIG_INET is not set but
> > CONFIG_INET_LRO=m, and the fix is to make CONFIG_PASEMI_MAC depend on
> > CONFIG_INET.
> 
> Ben, you can't just revert this by itself.
> 
> That knowingly breaks the build.
> 
> If you want the tristate back, you must do it after or at the
> same time as fixing the driver deps.

The fact that the driver dependencies are broken has nothing to do with
whether CONFIG_INET_LRO is boolean or tristate.  You fixed a problem
that didn't exist rather than the problem that did.

Ben.

-- 
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.