From: Joe Perches <joe@perches•com>
To: Casey Leedom <leedom@chelsio•com>
Cc: netdev@vger•kernel.org, davem@davemloft•net
Subject: Re: [PATCH 01/10] cxgb4vf: minor comment/symbolic name cleanup.
Date: Wed, 10 Nov 2010 19:19:38 -0800 [thread overview]
Message-ID: <1289445578.15905.173.camel@Joe-Laptop> (raw)
In-Reply-To: <1289441052-4925-1-git-send-email-leedom@chelsio.com>
On Wed, 2010-11-10 at 18:04 -0800, Casey Leedom wrote:
> Minor cleanup of comments and symbolic constant names for clarity.
> diff --git a/drivers/net/cxgb4vf/cxgb4vf_main.c b/drivers/net/cxgb4vf/cxgb4vf_main.c
> index 6de5e2e..f5259a1 100644
> --- a/drivers/net/cxgb4vf/cxgb4vf_main.c
> +++ b/drivers/net/cxgb4vf/cxgb4vf_main.c
> @@ -280,7 +280,7 @@ static void name_msix_vecs(struct adapter *adapter)
> const struct port_info *pi = netdev_priv(dev);
> int qs, msi;
>
> - for (qs = 0, msi = MSIX_NIQFLINT;
> + for (qs = 0, msi = MSIX_IQFLINT;
> qs < pi->nqsets;
> qs++, msi++) {
This for now fits on a single line.
> diff --git a/drivers/net/cxgb4vf/t4vf_hw.c b/drivers/net/cxgb4vf/t4vf_hw.c
> index ea1c123..2180181 100644
> --- a/drivers/net/cxgb4vf/t4vf_hw.c
> +++ b/drivers/net/cxgb4vf/t4vf_hw.c
> @@ -1257,7 +1257,7 @@ int t4vf_eth_eq_free(struct adapter *adapter, unsigned int eqid)
> */
> int t4vf_handle_fw_rpl(struct adapter *adapter, const __be64 *rpl)
> - struct fw_cmd_hdr *cmd_hdr = (struct fw_cmd_hdr *)rpl;
> + const struct fw_cmd_hdr *cmd_hdr = (const struct fw_cmd_hdr *)rpl;
> @@ -1265,7 +1265,7 @@ int t4vf_handle_fw_rpl(struct adapter *adapter, const __be64 *rpl)
> - const struct fw_port_cmd *port_cmd = (void *)rpl;
> + const struct fw_port_cmd *port_cmd = (const void *)rpl;
might be better to have a consistent casting style.
1st uses a direct cast, 2nd an implicit one.
next prev parent reply other threads:[~2010-11-11 3:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-11 2:01 [PATCH 00/10] cxgb4vf: a number of bug fixes and minor cleanup Casey Leedom
2010-11-11 2:04 ` [PATCH 01/10] cxgb4vf: minor comment/symbolic name cleanup Casey Leedom
2010-11-11 3:19 ` Joe Perches [this message]
2010-11-11 17:17 ` Casey Leedom
2010-11-11 2:04 ` [PATCH 02/10] cxgb4vf: don't implement trivial (and incorrect) ndo_select_queue() Casey Leedom
2010-11-11 2:04 ` [PATCH 03/10] cxgb4vf: fix bug in Generic Receive Offload Casey Leedom
2010-11-11 2:04 ` [PATCH 04/10] cxgb4vf: fix some errors in Gather List to skb conversion Casey Leedom
2010-11-11 2:04 ` [PATCH 05/10] cxgb4vf: flesh out PCI Device ID Table Casey Leedom
2010-11-11 2:04 ` [PATCH 06/10] cxgb4vf: fix up "Section Mismatch" compiler warning Casey Leedom
2010-11-11 2:04 ` [PATCH 07/10] cxgb4vf: Fail open if link_start() fails Casey Leedom
2010-11-11 2:04 ` [PATCH 08/10] cxgb4vf: Advertise NETIF_F_TSO_ECN Casey Leedom
2010-11-11 2:04 ` [PATCH 09/10] cxgb4vf: Mark "UDP [RSS Hash] Enable" as a 1-bit field Casey Leedom
2010-11-11 2:04 ` [PATCH 10/10] cxgb4vf: add call to Firmware to reset VF State Casey Leedom
2010-11-11 17:33 ` [PATCH 00/10] cxgb4vf: a number of bug fixes and minor cleanup David Miller
2010-11-11 17:40 ` Casey Leedom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1289445578.15905.173.camel@Joe-Laptop \
--to=joe@perches$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=leedom@chelsio$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox