Subject: Re: [PATCH] tcp: restrict net.ipv4.tcp_adv_min_scale (#20312)

From: Ben Hutchings <[email-masked]>
Date: Mon, 15 Nov 2010 14:18:42 +0000

On Sun, 2010-11-14 at 22:14 +0200, Alexey Dobriyan wrote:
> On Sun, Nov 14, 2010 at 08:49:43PM +0100, Eric Dumazet wrote:
> > > +static int _minus_31 = -31;
> > > +static int _31 = 31;
> > 
> > Please use normal symbols, not starting by underscore.
> 
> static int thirty_one = 31? :-)

How about, oh, I don't know, adv_win_scale_{min,max}?

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.