Subject: Re: [PATCH 5/6] forcedeth: use KERN_ facility level in printk

From: Joe Perches <[email-masked]>
Date: Sun, 28 Nov 2010 01:11:43 -0800

On Sun, 2010-11-28 at 10:05 +0100, Michał Mirosław wrote:
> 2010/11/27 Joe Perches <[email-masked]>:
> > On Sat, 2010-11-27 at 19:04 +0000, Ben Hutchings wrote:
> >> On Sat, 2010-11-27 at 19:39 +0100, Szymon Janc wrote:
> >> > diff --git a/drivers/net/forcedeth.c b/drivers/net/forcedeth.c
> >> > index 2f092d7..a2b6681 100644
> >> > @@ -958,7 +958,7 @@ static int reg_delay(struct net_device *dev, int offset, u32 mask, u32 target,
[]
> >> > -                           printk("%s", msg);
> >> > +                           printk(KERN_WARNING "%s", msg);
> >> No, msg already includes a log level.
> > True.  The messages are still broken though.
> > Some have trailing newlines, others not.
> > It'd be better to move the msg after the reg_delay
> > call and add the missing newlines.
> [...]
> > diff --git a/drivers/net/forcedeth.c b/drivers/net/forcedeth.c
> > @@ -1547,9 +1544,9 @@ static void nv_stop_rx(struct net_device *dev)
[]
> > -       reg_delay(dev, NvRegReceiverStatus, NVREG_RCVSTAT_BUSY, 0,
> > -                       NV_RXSTOP_DELAY1, NV_RXSTOP_DELAY1MAX,
> > -                       KERN_INFO "nv_stop_rx: ReceiverStatus remained busy");
> > +       if (reg_delay(dev, NvRegReceiverStatus, NVREG_RCVSTAT_BUSY, 0,
> > +                     NV_RXSTOP_DELAY1, NV_RXSTOP_DELAY1MAX))
> > +               printk(KERN_INFO "nv_stop_rx: ReceiverStatus remained busy\n");
> You could change it to dev_info() and friends in one go.

Yeah, I did that in a local tree for all logging calls,
(dprintk->netdev_dbg, printk->netdev_<level> etc) but I'll
wait until Szymon's patches are applied or nacked.