Subject: Re: [PATCH 3/3] ifb: move tq from ifb_private

From: jamal <[email-masked]>
Date: Sat, 04 Dec 2010 09:18:02 -0500

On Sat, 2010-12-04 at 13:55 +0800, Changli Gao wrote:
> tq is only used in ri_tasklet, so we move it from ifb_private to a
> stack variable of ri_tasklet.
> 
> skb_queue_splice_tail_init() is used instead of the open coded and slow
> one.

I like the splice idea but this patch makes me twitch
a little. What test setup did you use to check it?

cheers,
jamal