From: Ben Hutchings <bhutchings@solarflare•com>
To: Matt Domsch <Matt_Domsch@dell•com>
Cc: Eilon Greenstein <eilong@broadcom•com>,
Dimitris Michailidis <dm@chelsio•com>,
Dmitry Kravkov <dmitry@broadcom•com>,
"davem@davemloft•net" <davem@davemloft•net>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"narendra_k@dell•com" <narendra_k@dell•com>,
"jordan_hargrave@dell•com" <jordan_hargrave@dell•com>
Subject: Re: [PATCH net-next] bnx2x: Add Nic partitioning mode (57712 devices)
Date: Fri, 17 Dec 2010 13:22:37 +0000 [thread overview]
Message-ID: <1292592157.3136.819.camel@localhost> (raw)
In-Reply-To: <20101217024509.GA5854@auslistsprd01.us.dell.com>
On Thu, 2010-12-16 at 20:45 -0600, Matt Domsch wrote:
> On Thu, Dec 09, 2010 at 04:49:25PM +0200, Eilon Greenstein wrote:
> > On Mon, 2010-12-06 at 10:21 -0800, Dimitris Michailidis wrote:
> > > Matt Domsch wrote:
> > ...
> > > /sys/class/net/<ifname>/dev_id indicates the physical port <ifname> is
> > > associated with. At least a few drivers set up dev_id this way.
> > >
> > >
> >
> > So we are on agreement? This can satisf all needs? If so, we will add
> > this scheme to the bnx2x as well.
>
> I don't think that's enough. Necessary, but not sufficient.
>
> If dev_id is a field that starts over with each PCI device (e.g. is
> used to distinguish multiple ports that share the same PCI
> device), that's enough to handle the Chelsio case, but not the NPAR &
> SR-IOV case.
>
> If the above is true, then a value of dev_id=0 for all 1:1 PCI Device
> : Port relations is fine, leaving the three drivers that set dev_id
> non-zero are all multi-port, single PCI device controllers.
>
> cxgb4/t4_hw.c: adap->port[i]->dev_id = j;
> mlx4/en_netdev.c: dev->dev_id = port - 1;
> sfc/siena.c: efx->net_dev->dev_id = EFX_OWORD_FIELD(reg, FRF_CZ_CS_PORT_NUM) - 1;
>
> Is that truly how these three controllers work: they set dev_id when
> there are multiple physical ports that a single PCI d/b/d/f drives?
[...]
In the case of sfc, each port has a separate PCI function. We read this
register field to find out which port we're talking to, as
virtualisation can alter the function number. I don't know about the
others.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2010-12-17 13:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-28 22:09 [PATCH net-next] bnx2x: Add Nic partitioning mode (57712 devices) Dmitry Kravkov
2010-11-29 6:01 ` Matt Domsch
2010-11-29 9:33 ` Eilon Greenstein
2010-12-06 17:35 ` Matt Domsch
2010-12-06 18:21 ` Dimitris Michailidis
2010-12-09 14:49 ` Eilon Greenstein
2010-12-17 2:45 ` Matt Domsch
2010-12-17 13:22 ` Ben Hutchings [this message]
2010-12-19 5:57 ` Matt Domsch
2010-12-19 21:21 ` Ben Hutchings
2010-12-17 23:13 ` Dimitris Michailidis
2010-12-19 5:49 ` Matt Domsch
2010-12-20 19:44 ` Dimitris Michailidis
2011-01-06 14:40 ` Eilon Greenstein
2010-12-01 20:40 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1292592157.3136.819.camel@localhost \
--to=bhutchings@solarflare$(echo .)com \
--cc=Matt_Domsch@dell$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dm@chelsio$(echo .)com \
--cc=dmitry@broadcom$(echo .)com \
--cc=eilong@broadcom$(echo .)com \
--cc=jordan_hargrave@dell$(echo .)com \
--cc=narendra_k@dell$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox