Subject: Re: [PATCH v2 04/16] net: Introduce new feature setting ops

From: Ben Hutchings <[email-masked]>
Date: Tue, 25 Jan 2011 11:26:01 +1000

On Mon, 2011-01-24 at 15:51 -0800, David Miller wrote:
> From: Michał Mirosław <[email-masked]>
> Date: Sat, 22 Jan 2011 23:14:13 +0100 (CET)
> 
> > This introduces a new framework to handle device features setting.
> > It consists of:
> >   - new fields in struct net_device:
> > 	+ hw_features - features that hw/driver supports toggling
> > 	+ wanted_features - features that user wants enabled, when possible
> >   - new netdev_ops:
> > 	+ feat = ndo_fix_features(dev, feat) - API checking constraints for
> > 		enabling features or their combinations
> > 	+ ndo_set_features(dev) - API updating hardware state to match
> > 		changed dev->features
> >   - new ethtool commands:
> > 	+ ETHTOOL_GFEATURES/ETHTOOL_SFEATURES: get/set dev->wanted_features
> > 		and trigger device reconfiguration if resulting dev->features
> > 		changed
> > 	+ ETHTOOL_GSTRINGS(ETH_SS_FEATURES): get feature bits names (meaning)
> > 
> > Signed-off-by: Michał Mirosław <[email-masked]>
> 
> Ok, I'll stop applying patches right before this one as I'd like to see
> at least some feedback from Ben wrt. the ethtool bits.
> 
> FWIW I like these changes (a lot). :-)

These are on my list to review.  I'm at LCA now (and not on work time)
but I'll try to get through them in the next day or two.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.