Subject: Re: [PATCH 06/17] mlx4_en: using new mlx4 interrupt scheme

From: Ben Hutchings <[email-masked]>
Date: Mon, 07 Mar 2011 12:41:55 +0000

On Mon, 2011-03-07 at 12:17 +0200, Yevgeny Petrilin wrote:
> Each RX ring will have its own interrupt vector, and TX rings will share one
> (we mostly use polling for TX completions).
> The vectors are assigned first time device is opened, and its name includes
> the interface name and ring number.
[...]
> --- a/drivers/net/mlx4/en_main.c
> +++ b/drivers/net/mlx4/en_main.c
[...]
> @@ -601,10 +602,19 @@ int mlx4_en_start_port(struct net_device *dev)
>  		goto cq_err;
>  	}
>  
> +	if (mdev->dev->caps.comp_pool && !priv->tx_vector) {
> +		sprintf(name , "%s_tx", priv->dev->name);
> +		if (mlx4_assign_eq(mdev->dev , name, &priv->tx_vector)) {
> +			mlx4_warn(mdev, "Failed Assigning an EQ to "
> +					"%s_tx ,Falling back to legacy "
> +					"EQ's\n", priv->dev->name);
> +		}
> +	}
[...]

If this string is being copied to the IRQ name, it should be
"<ifname>-tx" not "<ifname>_tx" for consistency with other drivers.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.