Subject: Re: patch for format issues and header bug in net/ipv4/icmp.c

From: Ben Hutchings <[email-masked]>
Date: Fri, 18 Mar 2011 19:41:01 +0000

On Sat, 2011-03-19 at 00:05 +0530, Jeffrin Jose wrote:
> hello ,
> 
> I have created a patch for net/ipv4/icmp.c
> using checkpatch.pl script to fix several warnings
> and an error.

You need to learn C programming before trying to correct C programs.
You should not just do what it takes to make checkpatch.pl happy.

Ben.

> I have attached the patch along with this mail.
> 
> /Thanks
> 

-- 
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.