From: Ben Hutchings <bhutchings@solarflare•com>
To: Bruce Allan <bruce.w.allan@intel•com>
Cc: netdev@vger•kernel.org, Sathya Perla <sathya.perla@emulex•com>,
Subbu Seetharaman <subbu.seetharaman@emulex•com>,
Ajit Khaparde <ajit.khaparde@emulex•com>,
Michael Chan <mchan@broadcom•com>,
Eilon Greenstein <eilong@broadcom•com>,
Divy Le Ray <divy@chelsio•com>, Don Fry <pcnet32@frontier•com>,
Jon Mason <jdmason@kudzu•us>,
Solarflare linux maintainers <linux-net-drivers@solarflare•com>,
Steve Hodgson <shodgson@solarflare•com>,
Stephen Hemminger <shemminger@linux-foundation•org>,
Matt Carlson <mcarlson@broadcom•com>
Subject: Re: [net-next-2.6 RFC PATCH v3] ethtool: allow custom interval for physical identification
Date: Fri, 15 Apr 2011 02:26:25 +0100 [thread overview]
Message-ID: <1302830785.5282.691.camel@localhost> (raw)
In-Reply-To: <20110413230910.16317.11372.stgit@gitlad.jf.intel.com>
On Wed, 2011-04-13 at 16:09 -0700, Bruce Allan wrote:
> When physical identification of an adapter is done by toggling the
> mechanism on and off through software utilizing the set_phys_id operation,
> it is done with a fixed duration for both on and off states. Some drivers
> may want to set a custom duration for the on/off intervals. This patch
> changes the API so the return code from the driver's entry point when it
> is called with ETHTOOL_ID_ACTIVE can specify the frequency at which to
> cycle the on/off states, and updates the drivers that have already been
> converted to use the new set_phys_id and use the synchronous method for
> identifying an adapter.
>
> The physical identification frequency set in the updated drivers is based
> on how it was done prior to the introduction of set_phys_id.
>
> Compile tested only. Also fixes a compiler warning in sfc.
>
> v2: drivers do not return -EINVAL for ETHOOL_ID_ACTIVE
> v3: fold patchset into single patch and cleanup per Ben's feedback
>
> Signed-off-by: Bruce Allan <bruce.w.allan@intel•com>
> Cc: Ben Hutchings <bhutchings@solarflare•com>
[...]
Acked-by: Ben Hutchings <bhutchings@solarflare•com>
--
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2011-04-15 1:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-13 23:09 [net-next-2.6 RFC PATCH v3] ethtool: allow custom interval for physical identification Bruce Allan
2011-04-14 18:55 ` Jon Mason
2011-04-15 1:26 ` Ben Hutchings [this message]
2011-04-15 4:19 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1302830785.5282.691.camel@localhost \
--to=bhutchings@solarflare$(echo .)com \
--cc=ajit.khaparde@emulex$(echo .)com \
--cc=bruce.w.allan@intel$(echo .)com \
--cc=divy@chelsio$(echo .)com \
--cc=eilong@broadcom$(echo .)com \
--cc=jdmason@kudzu$(echo .)us \
--cc=linux-net-drivers@solarflare$(echo .)com \
--cc=mcarlson@broadcom$(echo .)com \
--cc=mchan@broadcom$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pcnet32@frontier$(echo .)com \
--cc=sathya.perla@emulex$(echo .)com \
--cc=shemminger@linux-foundation$(echo .)org \
--cc=shodgson@solarflare$(echo .)com \
--cc=subbu.seetharaman@emulex$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox