Subject: Re: [PATCH net-next 3/3] net: fullly using NETIF_F_ALL_TSO

From: Ben Hutchings <[email-masked]>
Date: Fri, 22 Apr 2011 15:14:22 +0100

On Fri, 2011-04-22 at 19:07 +0800, Shan Wei wrote:
> Fullly using NETIF_F_ALL_TSO.
> And some code style tuning. Just compile test.
[...]

This is wrong.  What if some other TSO feature is defined and added to
NETIF_F_ALL_TSO later?  (This is unlikely, but hopefully you see that it
is conceptually wrong to claim 'all' features.)

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.