Subject: Re: [PATCH net-next] ethtool: Add 20G bit definitions

From: Ben Hutchings <[email-masked]>
Date: Mon, 09 May 2011 13:50:48 +0100

On Mon, 2011-05-09 at 13:16 +0300, Yaniv Rosner wrote:
> On Sun, 2011-05-08 at 15:43 -0700, David Miller wrote:
> > From: "Yaniv Rosner" <[email-masked]>
> > Date: Tue, 3 May 2011 10:30:08 +0300
> > 
> > > Add 20G supported and advertising bit definitions.
> > > 20G will be supported with the 57840 chips.
> > > 
> > > 
> > > Signed-off-by: Yaniv Rosner <[email-masked]>
> > > Signed-off-by: Eilon Greenstein <[email-masked]>
> > 
> > Applied to net-next-2.6, thanks.
> > 
> Ben,
> Please note that I haven't added new definition for 20000 link speed
> because my understanding is that it no longer required.
> Let me know if you think it is required, mainly for the speed
> extension in the ethtool application.

There is no need (yet) for specific support of the speed.  However you
should provide a patch for ethtool to make it report these flags in the
advertised/lp_advertised/supported masks.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.