From: Ben Hutchings <bhutchings@solarflare•com>
To: David Miller <davem@davemloft•net>
Cc: shemminger@vyatta•com, gthelen@google•com,
shemminger@linux-foundation•org, netdev@vger•kernel.org,
linux-kernel@vger•kernel.org
Subject: Re: [PATCH] sky2: avoid using uninitialized variable
Date: Fri, 17 Jun 2011 04:51:35 +0100 [thread overview]
Message-ID: <1308282695.11457.48.camel@localhost> (raw)
In-Reply-To: <20110616.231018.84570655636629416.davem@davemloft.net>
On Thu, 2011-06-16 at 23:10 -0400, David Miller wrote:
> From: Stephen Hemminger <shemminger@vyatta•com>
> Date: Tue, 14 Jun 2011 00:02:30 -0400
>
> > In my experience if phy reads once successfully, it is going
> > to read every time. If there is a problem it only happens on
> > the first access (powered off, bad timing, etc).
>
> It also happens when the PHY can't get a response for a certain
> register, for whatever reason, before internal hw timeouts trigger.
>
> Please, check all MII accesses. That's what I do in every driver
> I've written.
It doesn't help that the mii_if_info operations are defined to never
return errors. This doesn't prevent drivers from doing so internally,
but it does set a bad example.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2011-06-17 3:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-13 21:21 [PATCH] sky2: avoid using uninitialized variable Greg Thelen
2011-06-13 22:12 ` Stephen Hemminger
2011-06-14 0:34 ` Greg Thelen
2011-06-14 4:02 ` Stephen Hemminger
2011-06-17 3:10 ` David Miller
2011-06-17 3:51 ` Ben Hutchings [this message]
2011-06-17 3:58 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1308282695.11457.48.camel@localhost \
--to=bhutchings@solarflare$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=gthelen@google$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=shemminger@linux-foundation$(echo .)org \
--cc=shemminger@vyatta$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox