From: Joe Perches <joe@perches•com>
To: Jon Mason <mason@myri•com>
Cc: davem@davemloft•net, netdev@vger•kernel.org,
Andrew Gallatin <gallatin@myri•com>
Subject: Re: [PATCH 3/9] myri10ge: rework parity error check and cleanup
Date: Mon, 27 Jun 2011 09:01:37 -0700 [thread overview]
Message-ID: <1309190497.3344.6.camel@Joe-Laptop> (raw)
In-Reply-To: <1309187108-12715-3-git-send-email-mason@myri.com>
On Mon, 2011-06-27 at 10:05 -0500, Jon Mason wrote:
> Clean up watchdog reset code:
> - unless there is a confirmed h/w fault, verify that a stuck
> slice is still stuck in the watchdog worker; if the slice is no
> longer stuck, abort the reset.
[]
> @@ -3498,23 +3536,24 @@ static void myri10ge_watchdog(struct work_struct *work)
[]
> + if (!reset_needed) {
> + netdev_err(mgp->dev, "not resetting\n");
> + return;
> + }
Probably the wrong level. Maybe netdev_dbg() or netdev_info()
next prev parent reply other threads:[~2011-06-27 16:01 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-27 15:05 [PATCH 1/9] myri10ge: ensure tx queues remain stopped Jon Mason
2011-06-27 15:05 ` [PATCH 2/9] myri10ge: Mask PCI Surprise Link Down Events Jon Mason
2011-06-29 13:02 ` David Miller
2011-06-27 15:05 ` [PATCH 3/9] myri10ge: rework parity error check and cleanup Jon Mason
2011-06-27 15:27 ` Ben Hutchings
2011-06-27 20:26 ` Jon Mason
2011-06-27 16:01 ` Joe Perches [this message]
2011-06-27 20:54 ` [PATCH 3/9 v2] " Jon Mason
2011-06-28 2:17 ` Joe Perches
2011-06-28 3:31 ` Jon Mason
2011-06-28 3:57 ` [PATCH 3/9 v3] " Jon Mason
2011-06-29 13:02 ` David Miller
2011-06-27 15:05 ` [PATCH 4/9] myri10ge: allow small_bytes = 0 Jon Mason
2011-06-29 13:03 ` David Miller
2011-06-27 15:05 ` [PATCH 5/9] myri10ge: add support for set_phys_id Jon Mason
2011-06-29 13:03 ` David Miller
2011-06-27 15:05 ` [PATCH 6/9] myri10ge: remove unnecessary read of PCI_CAP_ID_EXP Jon Mason
2011-06-29 13:03 ` David Miller
2011-06-27 15:05 ` [PATCH 7/9] myri10ge: misc style cleanups Jon Mason
2011-06-27 16:05 ` Joe Perches
2011-06-27 20:56 ` [PATCH 7/9 v2] " Jon Mason
2011-06-29 13:03 ` David Miller
2011-06-27 15:05 ` [PATCH 8/9] myri10ge: update version Jon Mason
2011-06-29 13:04 ` David Miller
2011-06-27 15:05 ` [PATCH 9/9] myri10ge: Update MAINTAINERS Jon Mason
2011-06-29 13:04 ` David Miller
2011-06-29 13:02 ` [PATCH 1/9] myri10ge: ensure tx queues remain stopped David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1309190497.3344.6.camel@Joe-Laptop \
--to=joe@perches$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=gallatin@myri$(echo .)com \
--cc=mason@myri$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox