From: Ben Hutchings <bhutchings@solarflare•com>
To: Joe Perches <joe@perches•com>
Cc: netdev@vger•kernel.org, "David S. Miller" <davem@davemloft•net>,
Neil Horman <nhorman@tuxdriver•com>,
linux-kernel@vger•kernel.org
Subject: Re: [PATCH] net/core: Convert to current logging forms
Date: Tue, 28 Jun 2011 21:21:41 +0100 [thread overview]
Message-ID: <1309292501.2771.48.camel@bwh-desktop> (raw)
In-Reply-To: <385ebf7e98e377e6e6c384beb961b65d4a95fb18.1309289792.git.joe@perches.com>
On Tue, 2011-06-28 at 12:40 -0700, Joe Perches wrote:
> Use pr_fmt, pr_<level>, and netdev_<level> as appropriate.
>
> Coalesce long formats.
[...]
> --- a/net/core/dev.c
> +++ b/net/core/dev.c
> @@ -72,6 +72,8 @@
> * - netif_rx() feedback
> */
>
> +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> +
[...]
KBUILD_MODNAME is presumably going to be "dev". That's not very
meaningful.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2011-06-28 20:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-28 19:40 [PATCH] net/core: Convert to current logging forms Joe Perches
2011-06-28 20:21 ` Ben Hutchings [this message]
2011-06-28 20:31 ` Joe Perches
2011-06-28 20:36 ` Ben Hutchings
2011-06-28 20:40 ` Joe Perches
2011-06-28 21:37 ` Joe Perches
2011-06-28 21:49 ` Stephen Hemminger
2011-06-28 21:55 ` Joe Perches
2011-06-29 11:11 ` Neil Horman
2011-06-29 11:55 ` David Miller
2011-06-29 15:24 ` Neil Horman
2011-06-29 14:57 ` Joe Perches
2011-06-30 9:55 ` WANG Cong
2011-06-30 17:10 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1309292501.2771.48.camel@bwh-desktop \
--to=bhutchings@solarflare$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=joe@perches$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nhorman@tuxdriver$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox