From: Ben Hutchings <bhutchings@solarflare•com>
To: Rick Jones <raj@tardy•cup.hp.com>
Cc: netdev@vger•kernel.org
Subject: Re: [PATCH net-next] Add ethtool -g support to 8139cp
Date: Wed, 05 Oct 2011 19:50:48 +0100 [thread overview]
Message-ID: <1317840648.2802.27.camel@bwh-desktop> (raw)
In-Reply-To: <20111005180854.3D68129003A8@tardy>
On Wed, 2011-10-05 at 11:08 -0700, Rick Jones wrote:
> From: Rick Jones <rick.jones2@hp•com>
>
> Add support for reporting ring sizes via ethtool -g to the 8139cp driver.
>
> Signed-off-by: Rick Jones <rick.jones2@hp•com>
>
> ---
>
> diff --git a/drivers/net/ethernet/realtek/8139cp.c b/drivers/net/ethernet/realtek/8139cp.c
> index c77d5af..1dcfe57 100644
> --- a/drivers/net/ethernet/realtek/8139cp.c
> +++ b/drivers/net/ethernet/realtek/8139cp.c
> @@ -1324,6 +1324,19 @@ static void cp_get_drvinfo (struct net_device *dev, struct ethtool_drvinfo *info
> strcpy (info->bus_info, pci_name(cp->pdev));
> }
>
> +static void cp_get_ringparam(struct net_device *dev,
> + struct ethtool_ringparam *ring)
> +{
> + ring->rx_max_pending = CP_RX_RING_SIZE;
> + ring->tx_max_pending = CP_TX_RING_SIZE;
> + ring->rx_mini_max_pending = 0;
> + ring->rx_jumbo_max_pending = 0;
> + ring->rx_pending = CP_RX_RING_SIZE;
> + ring->tx_pending = CP_TX_RING_SIZE;
> + ring->rx_mini_pending = 0;
> + ring->rx_jumbo_pending = 0;
> +}
You generally don't need to set fields to zero in ethtool 'get'
operations, as the ethtool core will initialise the entire structure to
zero.
Ben.
> static int cp_get_regs_len(struct net_device *dev)
> {
> return CP_REGS_SIZE;
> @@ -1525,6 +1538,7 @@ static const struct ethtool_ops cp_ethtool_ops = {
> .get_eeprom_len = cp_get_eeprom_len,
> .get_eeprom = cp_get_eeprom,
> .set_eeprom = cp_set_eeprom,
> + .get_ringparam = cp_get_ringparam,
> };
>
> static int cp_ioctl (struct net_device *dev, struct ifreq *rq, int cmd)
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger•kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2011-10-05 18:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-05 18:08 [PATCH net-next] Add ethtool -g support to 8139cp Rick Jones
2011-10-05 18:50 ` Ben Hutchings [this message]
2011-10-05 21:53 ` David Miller
2011-10-07 16:38 ` Rick Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1317840648.2802.27.camel@bwh-desktop \
--to=bhutchings@solarflare$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=raj@tardy$(echo .)cup.hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox