From: Joe Perches <joe@perches•com>
To: Rob Herring <robherring2@gmail•com>
Cc: netdev@vger•kernel.org, devicetree-discuss@lists•ozlabs.org,
Rob Herring <rob.herring@calxeda•com>
Subject: Re: [PATCH] net: add calxeda xgmac ethernet driver
Date: Wed, 26 Oct 2011 20:35:52 -0700 [thread overview]
Message-ID: <1319686552.21924.47.camel@Joe-Laptop> (raw)
In-Reply-To: <1319684206-473-1-git-send-email-robherring2@gmail.com>
On Wed, 2011-10-26 at 21:56 -0500, Rob Herring wrote:
> Add support for the XGMAC 10Gb ethernet device in the Calxeda Highbank
> SOC.
Hi Rob, just trivia:
Most of the logging dev_<level> messages
should be netdev_<level>
Adding #define pr_fmt KBUILD_MODNAME ": " fmt
before any #include would be useful to prefix
the module name to pr_<level> output.
> +static int desc_get_tx_status(struct xgmac_extra_stats *x,
> + struct xgmac_dma_desc *p, void __iomem *ioaddr)
> +{
[]
> + if (status & TXDESC_JABBER_TIMEOUT) {
> + pr_debug("\tjabber_timeout error\n");
> + x->tx_jabber++;
> + }
Adding pr_fmt, the output would become:
calxeda_xgmac: jabber_timeout error
[]
> +static void xgmac_rx_refill(struct xgmac_priv *priv)
> + dev_dbg(priv->device, "rx ring: head %d, tail %d\n",
> + priv->rx_head, priv->rx_tail);
netdev_dbg(priv->dev, "rx ring: head %d, tail %d\n",
etc...)
[]
> +static int xgmac_open(struct net_device *dev)
> +{
[]
> + if (!is_valid_ether_addr(dev->dev_addr)) {
> + random_ether_addr(dev->dev_addr);
> + dev_dbg(priv->device, "generated random MAC address %pM\n",
> + dev->dev_addr);
netdev_dbg(dev, "generated random MAC address %pM\n",
dev->dev_addr);
etc...
cheers, Joe
next prev parent reply other threads:[~2011-10-27 3:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-27 2:56 [PATCH] net: add calxeda xgmac ethernet driver Rob Herring
2011-10-27 3:35 ` Joe Perches [this message]
2011-10-27 9:28 ` saeed bishara
2011-11-04 16:57 ` Grant Likely
[not found] ` <CACxGe6sAFUwQc5Nk=gGLC+si-_C32AWu=E14vBkSm7YCFhazFg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-11-04 16:57 ` Grant Likely
2011-11-04 20:52 ` Rob Herring
-- strict thread matches above, loose matches on Subject: below --
2011-11-16 2:46 Rob Herring
2011-11-18 19:54 ` David Miller
2011-11-18 22:36 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1319686552.21924.47.camel@Joe-Laptop \
--to=joe@perches$(echo .)com \
--cc=devicetree-discuss@lists$(echo .)ozlabs.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=rob.herring@calxeda$(echo .)com \
--cc=robherring2@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox