From: Ben Hutchings <bhutchings@solarflare•com>
To: David Miller <davem@davemloft•net>
Cc: <mchan@broadcom•com>, <mcarlson@broadcom•com>, <netdev@vger•kernel.org>
Subject: Re: [PATCH] Add ethtool to mii advertisment conversion helpers
Date: Thu, 17 Nov 2011 02:29:27 +0000 [thread overview]
Message-ID: <1321496967.2885.65.camel@deadeye> (raw)
In-Reply-To: <20111116.203850.1548671990526136907.davem@davemloft.net>
On Wed, 2011-11-16 at 20:38 -0500, David Miller wrote:
> From: "Michael Chan" <mchan@broadcom•com>
> Date: Wed, 16 Nov 2011 17:21:32 -0800
>
> >
> > On Wed, 2011-11-16 at 17:16 -0800, Matt Carlson wrote:
> >> > Finally, do these need to be inline?
> >>
> >> I don't have a strong preference here either. Phy code tends to be
> >> slower, so there isn't really a strong performance argument. The
> >> implementations don't seem to be so large to argue against it though.
> >> Would you prefer they not be inlined?
> >>
> >
> > Since we are defining these in .h file, they need to be inline, right?
> > Otherwise multiple source files including the same .h file will have
> > conflict.
>
> Yes, if you keep them in the header you have to keep them inline.
>
> Ben, by suggesting to not inline them, is implicitly saying to put
> them out in a seperate *.c file somewhere, perhaps net/core/ethtool.c
> or similar. With appropriate EXPORT_SYMBOL() added.
I was thinking of putting them in drivers/net/mii.c, like the other
functions declared extern in include/linux/mii.h. That would require
'select MII' in Kconfig for the drivers using them.
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2011-11-17 2:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-15 22:00 [PATCH] Add ethtool to mii advertisment conversion helpers Matt Carlson
2011-11-16 22:36 ` David Miller
2011-11-16 22:56 ` Matt Carlson
2011-11-17 0:34 ` Ben Hutchings
2011-11-17 1:16 ` Matt Carlson
2011-11-17 1:21 ` Michael Chan
2011-11-17 1:38 ` David Miller
2011-11-17 2:29 ` Ben Hutchings [this message]
2011-11-17 1:29 ` Ben Hutchings
2011-11-17 2:06 ` Matt Carlson
2011-11-17 2:45 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1321496967.2885.65.camel@deadeye \
--to=bhutchings@solarflare$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=mcarlson@broadcom$(echo .)com \
--cc=mchan@broadcom$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox