Subject: Re: Open vSwitch Design

From: jamal <hadi-fAAogVwAN2Kw5LPnMra/[email-masked]>
Date: Fri, 25 Nov 2011 06:34:22 -0500

Hrm. I forgot about the flow classifier - it may be what the openflow
folks need. It is more friendly for the well defined tuples than u32.

But what do you mean "refactor"? I can already use this classifier
and attach actions to set policy in the kernel.

cheers,
jamal

On Fri, 2011-11-25 at 07:36 +0100, Eric Dumazet wrote:

> > > 
> > > Maybe its time to factorize the thing, eventually use it in a third
> > > component (Open vSwitch...)
> > 
> > Yes.
> 
> A third reason to do that anyway is that net/sched/sch_sfb.c should use
> __skb_get_rxhash() providing the perturbation itself, and not use the
> standard (hashrnd) one ).
> 
> Right now, if two flows share same rxhash, the double SFB hash will also
> share the same final hash.
> 
> (This point was mentioned by Florian Westphal)
> 
> 
>