Subject: Re: [PATCH 1/2] bna: Added flash sub-module and ethtool eeprom entry points.

From: Ben Hutchings <[email-masked]>
Date: Fri, 23 Dec 2011 09:44:22 +0000

On Thu, 2011-12-22 at 15:29 -0800, [email-masked] wrote:
> From: Krishna Gudipati <[email-masked]>
> 
> Change details:
> 	- The patch adds flash sub-module to the bna driver.
> 	- Added ethtool set_eeprom() and get_eeprom() entry points to
> 	  support flash partition read/write operations.
[...]

I'm not going to say this is wrong, but we didn't find the EEPROM
operations suitable for firmware upgrade.  I have a couple of questions:

1. How long can a single set_eeprom() operation take?
2. Have you considered implementing the flash_device() operation or an
MTD driver?

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.