From: Ben Hutchings <bhutchings@solarflare•com>
To: "Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@intel•com>
Cc: Michal Miroslaw <mirqus@gmail•com>,
"Skidmore, Donald C" <donald.c.skidmore@intel•com>,
"Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel•com>,
"davem@davemloft•net" <davem@davemloft•net>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"gospo@redhat•com" <gospo@redhat•com>,
"sassmann@redhat•com" <sassmann@redhat•com>
Subject: RE: [net-next 8/9] ixgbe: add interface to export thermal data
Date: Fri, 6 Jan 2012 18:25:09 +0000 [thread overview]
Message-ID: <1325874309.25896.2.camel@bwh-desktop> (raw)
In-Reply-To: <363B5007A0D944459CBE9CF6A37B891B01E718@ORSMSX104.amr.corp.intel.com>
On Fri, 2012-01-06 at 18:20 +0000, Waskiewicz Jr, Peter P wrote:
> > -----Original Message-----
> > From: Ben Hutchings [mailto:bhutchings@solarflare•com]
> > Sent: Friday, January 06, 2012 10:09 AM
> > To: Waskiewicz Jr, Peter P
> > Cc: Michal Miroslaw; Skidmore, Donald C; Kirsher, Jeffrey T;
> > davem@davemloft•net; netdev@vger•kernel.org; gospo@redhat•com;
> > sassmann@redhat•com
> > Subject: RE: [net-next 8/9] ixgbe: add interface to export thermal data
> >
> > On Fri, 2012-01-06 at 17:55 +0000, Waskiewicz Jr, Peter P wrote:
> > > > -----Original Message-----
> > > > From: Michał Mirosław [mailto:mirqus@gmail•com]
> > > > Sent: Thursday, January 05, 2012 3:51 PM
> > > > To: Skidmore, Donald C
> > > > Cc: Ben Hutchings; Kirsher, Jeffrey T; davem@davemloft•net;
> > > > netdev@vger•kernel.org; gospo@redhat•com; sassmann@redhat•com;
> > > > Waskiewicz Jr, Peter P
> > > > Subject: Re: [net-next 8/9] ixgbe: add interface to export thermal
> > > > data
> > > >
> > > > Drivers outside of drivers/hwmon just select HWMON in Kconfig. This
> > > > adds a 3kB .c file to the kernel build for the first one that needs it.
> > >
> > > This is where we run into issues though. We can put this dependency
> > > in, but customers don't pull upstream kernels, they rely on the OSV's
> > > to distribute updates. The customer doesn't want HWMON, and if their
> > > kernel doesn't ship with HWMON support for ixgbe, then we're sunk.
> >
> > So if !IS_ENABLED(CONFIG_HWMON), don't try to create an hwmon device,
> > but create the attributes anyway.
>
> And if CONFIG_HWMON is not enabled, are we then responsible for
> creating the hwmon area in sysfs to link in our attributes? That
> would make even less sense to include HWMON attributes if HWMON isn't
> built in.
No, the attributes actually appear under the parent device.
> > > The point is what we're trying to implement, based on what our customers'
> > > requirements are, is something completely different than what HWMON is
> > > providing. Trying to wedge HWMON onto this framework we're trying to
> > > provide just overcomplicates the entire thing we're trying to provide.
> > > It's a generic interface to generic data in our drivers,
> > [...]
> >
> > It sounds like you want to provide a "generic" ixgbe interface on different
> > operating systems. But that is not a valid argument for an in-tree driver.
>
> No, we're trying to provide a generic ixgbe interface on Linux
> systems. The reality is different OSV's pull our driver from upstream
> to build their distros,
Yes we know.
[...]
> The reality is these attributes of our thermal sensors are about 5% of
> the data we need to export.
[...]
And I think all you need to do is (1) give these particular attributes
the right names and (2) create a child hwmon device if possible. Is
that so hard?
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2012-01-06 18:25 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-23 9:09 [net-next 0/9][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
2011-12-23 9:09 ` [net-next 1/9] ixgbevf: Fix register defines to correctly handle complex expressions Jeff Kirsher
2011-12-23 9:09 ` [net-next 2/9] igb: Add flow control advertising to ethtool setting Jeff Kirsher
2011-12-23 9:09 ` [net-next 3/9] ixgbe: fix incorrect PHY register reads Jeff Kirsher
2011-12-23 9:09 ` [net-next 4/9] ixgbe: fix typo's Jeff Kirsher
2011-12-23 9:09 ` [net-next 5/9] ixgbe: add write flush in ixgbe_clock_out_i2c_byte() Jeff Kirsher
2011-12-23 9:09 ` [net-next 6/9] ixgbe: add support for new 82599 device id Jeff Kirsher
2011-12-23 9:09 ` [net-next 7/9] ixgbe: add support functions for gathering thermal data sensor Jeff Kirsher
2011-12-23 13:01 ` Francois Romieu
2011-12-23 18:27 ` Skidmore, Donald C
2011-12-23 20:43 ` Francois Romieu
2011-12-23 9:09 ` [net-next 8/9] ixgbe: add interface to export thermal data Jeff Kirsher
2011-12-23 13:01 ` Francois Romieu
2011-12-23 18:29 ` Skidmore, Donald C
2011-12-23 20:45 ` Francois Romieu
2011-12-23 17:58 ` Michał Mirosław
2011-12-24 10:22 ` Ben Hutchings
2012-01-05 17:53 ` Skidmore, Donald C
2012-01-05 18:36 ` Ben Hutchings
2012-01-05 22:57 ` Skidmore, Donald C
2012-01-05 23:50 ` Michał Mirosław
2012-01-06 17:55 ` Waskiewicz Jr, Peter P
2012-01-06 18:09 ` Ben Hutchings
2012-01-06 18:20 ` Waskiewicz Jr, Peter P
2012-01-06 18:25 ` Ben Hutchings [this message]
2012-01-09 18:08 ` Waskiewicz Jr, Peter P
2012-01-09 18:49 ` Ben Hutchings
2012-01-06 3:03 ` Stephen Hemminger
2011-12-23 9:09 ` [net-next 9/9] ixgbe: add support for new 82599 device Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1325874309.25896.2.camel@bwh-desktop \
--to=bhutchings@solarflare$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=donald.c.skidmore@intel$(echo .)com \
--cc=gospo@redhat$(echo .)com \
--cc=jeffrey.t.kirsher@intel$(echo .)com \
--cc=mirqus@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=peter.p.waskiewicz.jr@intel$(echo .)com \
--cc=sassmann@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox