From: Dan Williams <dcbw@redhat•com>
To: Lennert Buytenhek <buytenh@wantstofly•org>
Cc: sedat.dilek@gmail•com,
"John W. Linville" <linville@tuxdriver•com>,
linux-wireless@vger•kernel.org, netdev@vger•kernel.org,
linux-kernel@vger•kernel.org, lautriv <admin@coldplug•net>,
Jim Cromie <jim.cromie@gmail•com>
Subject: Re: [PATCH] mwl8k: Add 0x2a02 PCI device-id (Marvell 88W8361)
Date: Mon, 07 May 2012 11:09:04 -0500 [thread overview]
Message-ID: <1336406944.2385.24.camel@dcbw.foobar.com> (raw)
In-Reply-To: <20120501125102.GN3157@wantstofly.org>
On Tue, 2012-05-01 at 14:51 +0200, Lennert Buytenhek wrote:
> On Sun, Apr 29, 2012 at 12:25:21AM +0200, Sedat Dilek wrote:
>
> > > On 1st sight, logs look fine:
> > >
> > > [21:52:52] <lautriv> [ 6.050967] ieee80211 phy0: 88w8361p v4,
> > > 00173f3bdde3, STA firmware 2.1.4.25
> > >
> > > But WLAN connection is not that fast and stable as lautriv reports
> > > (several abnormalities were observed).
> > >
> > > I requested a tarball which includes:
> > > * dmesg (Linux-3.3.3)
> > > * e_n_a (/etc/network/interfaces)
> > > * ifconfig output
> > > * iwconfig output
> > > * iw_phy output
> > > * ps_axu (WPA) output
> > >
> > > lautriv will be so kind to be around on #linux-wireless/Freenode the
> > > next days (UTC+2: German/Swiss local-time).
> > > Just ping him.
> > >
> > > Hope you have fun, together!
> > >
> > > - Sedat -
> >
> > A new tarball from lautriv with same outputs as before, but now tested
> > with Linux-3.4-rc4.
>
> The output looks good enough for me to ACK adding the PCI ID.
>
> Can the firmware being used here be submitted to the linux-firmware
> git tree?
So Marvell sent John a driver for TopDog a long time ago, which he put
up on kernel.org. That driver was reworked by Louis and put up in a git
tree, but both were lost to the kernel.org hack. I have git backups of
both git trees. I put Louis' cleanup here:
http://people.redhat.com/dcbw/mrvl_cb82.tar.bz2
That driver (mrvl_cb82) has the following PCI IDs:
static const struct pci_device_id mwl_id_tbl[] __devinitdata = {
{ PCI_VDEVICE(MARVELL, 0x2a02), 0 },
{ PCI_VDEVICE(MARVELL, 0x2a03), 1 },
{ PCI_VDEVICE(MARVELL, 0x2a06), 2 },
{ PCI_VDEVICE(MARVELL, 0x2a07), 3 },
{ PCI_VDEVICE(MARVELL, 0x2a04), 4 },
{ PCI_VDEVICE(MARVELL, 0x2a08), 5 },
{ PCI_VDEVICE(MARVELL, 0x2a0a), 6 },
{ PCI_VDEVICE(MARVELL, 0x2a0b), 7 },
{ PCI_VDEVICE(MARVELL, 0x2a0c), 8 },
{ 0 }
};
and supposedly works for CB82 + CB85. The firmware helper for CB82
looks pretty close to the mwl8k one.
The firmware API exposed by mrvl_cb82 looks very close to mwl8k
actually. I only checked the HostCmd bits, not the structures, so I
would expect a few differences. There are some commands that mwl8k
exposes that mrvl_cb82 does not and vice versa, but I'm not sure if the
drivers actually use those commands.
Hope this helps.
Dan
next prev parent reply other threads:[~2012-05-07 16:09 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-27 9:08 [PATCH] mwl8k: Add 0x2a02 PCI device-id (Marvell 88W8361) Sedat Dilek
2012-04-27 9:14 ` Lennert Buytenhek
2012-04-27 9:22 ` Sedat Dilek
2012-04-27 9:40 ` Lennert Buytenhek
2012-04-27 9:42 ` Sedat Dilek
2012-04-27 9:46 ` Lennert Buytenhek
2012-04-27 9:56 ` Sedat Dilek
2012-04-27 9:58 ` Lennert Buytenhek
2012-04-27 10:12 ` Sedat Dilek
2012-04-27 10:17 ` Lennert Buytenhek
2012-04-27 10:57 ` Sedat Dilek
[not found] ` <CA+icZUUnJPeDmL9xXfvj62an40bXwwaOnrJmxmLN_cBt9PyCZA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-04-27 13:29 ` Sedat Dilek
2012-04-27 18:58 ` Lennert Buytenhek
2012-04-27 21:53 ` Sedat Dilek
[not found] ` <CA+icZUWQmCRdjucb4+Nf24_zbJ4fzzp7zjqhKjXE6U01rppDfA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-04-28 22:25 ` Sedat Dilek
[not found] ` <CA+icZUXSaEMA=KbQP9UQcU6ZMBh8QD2sv-O=6r_Ly8is==gvSA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-04-28 22:36 ` Jim Cromie
2012-04-28 22:49 ` Sedat Dilek
2012-04-28 23:11 ` Jim Cromie
[not found] ` <CAJfuBxwz2PmNY37VB7Wx+GdQcOcS6Y96EM_JNtvs-dyv-imL6g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-04-28 23:26 ` Sedat Dilek
[not found] ` <CA+icZUXrGuY+0GLJCmL9CH7i7vnvXAyAE2vXNAXM_3Q30B4nPA@mail.gmail .com>
[not found] ` <CA+icZUXrGuY+0GLJCmL9CH7i7vnvXAyAE2vXNAXM_3Q30B4nPA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-04-29 17:34 ` admin
[not found] ` <4F9D7BB8.4000007-kieEQ4o6Pv7k1uMJSBkQmQ@public.gmane.org>
2012-04-29 17:49 ` Sedat Dilek
[not found] ` <CA+icZUUj8utveS7e6wh-BU3A4yk4FsiQ9YGRk6BowL+ex35wFw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-04-30 9:53 ` Helmut Stengele
2012-05-01 12:51 ` Lennert Buytenhek
2012-05-01 12:51 ` Lennert Buytenhek
2012-05-01 13:54 ` Sedat Dilek
2012-05-01 15:49 ` Lennert Buytenhek
[not found] ` <CA+icZUV=qtXwVxb+uvQJcsza0y+6k2LHJFFPnECY0M=QWBexaQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-05-02 1:12 ` Pat Erley
[not found] ` <4FA089F9.1020602-Jx9fsTfDDR3YtjvyW6yDsg@public.gmane.org>
2012-05-02 2:38 ` Lennert Buytenhek
2012-05-02 8:58 ` Sedat Dilek
2012-05-02 7:59 ` Arend van Spriel
2012-05-02 13:53 ` Ben Hutchings
2012-05-07 16:09 ` Dan Williams [this message]
[not found] ` <1336406944.2385.24.camel-wKZy7rqYPVb5EHUCmHmTqw@public.gmane.org>
2012-05-07 16:42 ` Dan Williams
2012-05-07 18:26 ` Adrian Chadd
2012-05-11 8:01 ` Helmut Stengele
2012-05-01 12:47 ` Lennert Buytenhek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1336406944.2385.24.camel@dcbw.foobar.com \
--to=dcbw@redhat$(echo .)com \
--cc=admin@coldplug$(echo .)net \
--cc=buytenh@wantstofly$(echo .)org \
--cc=jim.cromie@gmail$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=linville@tuxdriver$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sedat.dilek@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox