Subject: Re: [PATCH v2 3/4] selftests: nettest: Add --{do,no}-bind-key-ifindex

From: David Ahern <[email-masked]>
Date: Thu, 14 Oct 2021 08:25:37 -0600

On 10/13/21 12:50 AM, Leonard Crestez wrote:
> @@ -1856,10 +1870,14 @@ static void print_usage(char *prog)
>  	"    -n num        number of times to send message\n"
>  	"\n"
>  	"    -M password   use MD5 sum protection\n"
>  	"    -X password   MD5 password for client mode\n"
>  	"    -m prefix/len prefix and length to use for MD5 key\n"
> +	"    --no-bind-key-ifindex: Force TCP_MD5SIG_FLAG_IFINDEX off\n"
> +	"    --do-bind-key-ifindex: Force TCP_MD5SIG_FLAG_IFINDEX on\n"
> +	"        (default: only if -I is passed)\n"

a nit:
just --bind-key-ifindex and --no-bind-key-ifindex

Reviewed-by: David Ahern <[email-masked]>