Subject: Re: [net-next PATCH 2/6] net: cacheline adjust struct inet_frags for better frag performance

From: Jesper Dangaard Brouer <[email-masked]>
Date: Tue, 29 Jan 2013 08:30:01 +0100

On Mon, 2013-01-28 at 23:23 -0500, David Miller wrote:
> From: Jesper Dangaard Brouer <[email-masked]>
> Date: Thu, 24 Jan 2013 15:04:20 +0100
> 
> > +	/* --- read-mostly cacheline boundary (was 24 bytes ago) --- */
> 
> This "24" is context dependent, I assume it applies to 64-bit builds
> rather than 32-bit ones.

True

> Either add the necessary details or just get rid of this part of the
> comment altogether.

I'll remove the comment altogether, and resubmit the patchset.

Thanks for your review. (Hope your flu is gone, and your backlog didn't
grow too big)

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Sr. Network Kernel Developer at Red Hat
  Author of http://www.iptv-analyzer.org
  LinkedIn: http://www.linkedin.com/in/brouer