From: Cong Wang <amwang@redhat•com>
To: Veaceslav Falico <vfalico@redhat•com>
Cc: netdev@vger•kernel.org, davem@davemloft•net,
Neil Horman <nhorman@tuxdriver•com>
Subject: Re: [PATCH] netconsole: release the spinlock before __netpoll_cleanup()
Date: Wed, 06 Mar 2013 22:51:21 +0800 [thread overview]
Message-ID: <1362581481.4435.23.camel@cr0> (raw)
In-Reply-To: <1362581203-8994-1-git-send-email-vfalico@redhat.com>
On Wed, 2013-03-06 at 15:46 +0100, Veaceslav Falico wrote:
> Commit 3335f0ca130c201f8680e97f63612053fbc16e22 removed spinlock unlocking
> before __netpoll_cleanup() in netconsole_netdev_event(), however we still
> might sleep in __netpoll_cleanup() - via synchronize_srcu(). Revert it and
> add a comment.
>
synchronize_srcu() was actually introduced by Neil:
commit ca99ca14c95ae49fb4c9cd3abf5f84d11a7e8a61
Author: Neil Horman <nhorman@tuxdriver•com>
Date: Tue Feb 5 08:05:43 2013 +0000
netpoll: protect napi_poll and poll_controller during dev_[open|
close]
Cc'ing him.
next prev parent reply other threads:[~2013-03-06 14:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-06 14:46 [PATCH] netconsole: release the spinlock before __netpoll_cleanup() Veaceslav Falico
2013-03-06 14:51 ` Cong Wang [this message]
2013-03-07 0:08 ` Neil Horman
2013-03-07 10:03 ` Veaceslav Falico
2013-03-07 14:43 ` Neil Horman
2013-03-07 21:14 ` David Miller
2013-03-10 15:25 ` Veaceslav Falico
2013-03-11 10:08 ` Veaceslav Falico
2013-03-11 11:30 ` Neil Horman
2013-03-11 11:39 ` Veaceslav Falico
2013-03-11 17:58 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1362581481.4435.23.camel@cr0 \
--to=amwang@redhat$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nhorman@tuxdriver$(echo .)com \
--cc=vfalico@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox