From: Cong Wang <amwang@redhat•com>
To: Sridhar Samudrala <sri@us•ibm.com>
Cc: netdev@vger•kernel.org, "David S. Miller" <davem@davemloft•net>
Subject: Re: [Patch net-next] vxlan: revert "vxlan: Bypass encapsulation if the destination is local"
Date: Thu, 11 Apr 2013 10:10:15 +0800 [thread overview]
Message-ID: <1365646215.25993.3.camel@cr0> (raw)
In-Reply-To: <1365530913.29336.50.camel@oc1677441337.ibm.com>
On Tue, 2013-04-09 at 11:08 -0700, Sridhar Samudrala wrote:
> On Tue, 2013-04-09 at 17:57 +0800, Cong Wang wrote:
> > From: Cong Wang <amwang@redhat•com>
> >
> > This reverts commit 9dcc71e1fdbb7aa10d92a3d35e8a201adc84abd0.
> > It apparently breaks my vxlan tests between different namespaces.
> >
> I haven't tried vxlan with network namespaces.
> This patch effects the following 2 code paths
> - when source and destination endpoints are on the same bridge and
> route short-circuiting is enabled. I guess you are not hitting
> this path as this is possible only if you specify 'rsc' flag when
> creating vxlan device.
No, I didn't specify this flag.
> - when source and destination endpoints belonging to different vni's
> are on 2 different bridges on the same host. encap bypass is done
> in this scenario by checking if rt_flags has RTCF_LOCAL set. I think
> you must be hitting this path and the following patch should fix
> it by only doing bypass if the source and dest devices belong to
> the same net. Can you try it and see if it fixes your tests?
I just tested it, unfortunately it doesn't work, the bug still exists.
If you need any other info, please let me know.
Thanks.
next prev parent reply other threads:[~2013-04-11 2:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-09 9:57 [Patch net-next] vxlan: revert "vxlan: Bypass encapsulation if the destination is local" Cong Wang
2013-04-09 17:16 ` David Miller
2013-04-09 18:08 ` Sridhar Samudrala
2013-04-10 14:29 ` Sergei Shtylyov
2013-04-11 2:10 ` Cong Wang [this message]
2013-04-11 4:53 ` Sridhar Samudrala
2013-04-11 5:55 ` Cong Wang
2013-04-11 6:33 ` Sridhar Samudrala
2013-04-11 23:59 ` Sridhar Samudrala
2013-04-12 8:05 ` Cong Wang
2013-04-12 19:19 ` David Miller
2013-04-12 23:07 ` Sridhar Samudrala
2013-04-12 23:17 ` David Miller
2013-04-15 2:31 ` Cong Wang
2013-04-15 4:20 ` Sridhar Samudrala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1365646215.25993.3.camel@cr0 \
--to=amwang@redhat$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sri@us$(echo .)ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox