Subject: Re: [Patch net-next] net: clean up skb headers code

From: Cong Wang <[email-masked]>
Date: Wed, 29 May 2013 14:48:06 +0800

On Tue, 2013-05-28 at 23:36 -0700, David Miller wrote:
> From: Cong Wang <[email-masked]>
> Date: Wed, 29 May 2013 14:09:00 +0800
> 
> > commit 1a37e412a0225fcba5587 (net: Use 16bits for *_headers
> > fields of struct skbuff) converts skb->*_header to u16,
> > therefore 1) we could just use 0xFFFFF instead of (__u16) ~0U
> > 2) some #if NET_SKBUFF_DATA_USES_OFFSET is useless now.
> > 
> > 
> > Cc: David S. Miller <[email-masked]>
> > Cc: Simon Horman <[email-masked]>
> > Signed-off-by: Cong Wang <[email-masked]>
> 
> I want to use something that will either break the build or
> automatically work if the type changes again.
> 
> So something like "X = (typeof(X)) ~0U;".

Yeah, this is even better. I will update this patch.

Thanks.