Subject: Re: [Patch net-next] icmp: avoid allocating large struct on stack

From: Cong Wang <[email-masked]>
Date: Sun, 02 Jun 2013 09:14:42 +0800

On Fri, 2013-05-31 at 22:22 -0700, Eric Dumazet wrote:
> On Sat, 2013-06-01 at 11:24 +0800, Cong Wang wrote:
> > From: Cong Wang <[email-masked]>
> > 
> > struct icmp_bxm is a large struct, reduce stack usage
> > by allocating it on heap.
> > 
> 
> Strange, I posted a patch like that some days ago.

Strange, why it isn't merged. :)

> 
> Please.
> 
> Read carefully this code and tell me if you do not leak memory.

Right, I missed some kfree.

> 
> For the record my patch was saving more stack space :

Please submit it as a normal patch?