Subject: Re: [Patch net-next 1/2] net: fix a compile error when CONFIG_NET_LL_RX_POLL is not set

From: Cong Wang <[email-masked]>
Date: Thu, 01 Aug 2013 16:08:07 +0800

On Thu, 2013-08-01 at 09:54 +0300, Eliezer Tamir wrote:
> On 01/08/2013 06:10, Cong Wang wrote:
> > From: Cong Wang <[email-masked]>
> > 
> > When CONFIG_NET_LL_RX_POLL is not set, I got:
> > 
> > net/socket.c: In function ‘sock_poll’:
> > net/socket.c:1165:4: error: implicit declaration of function ‘sk_busy_loop’ [-Werror=implicit-function-declaration]
> > 
> > Fix this by adding a nop when !CONFIG_NET_LL_RX_POLL.
> > 
> 
> Good catch!
> 
> There is a placeholder function, but it has a typo in the name.
> With all the renaming I made a mistake and called the do-nothing
> function sk_busy_poll while the implemented function is called sk_busy_loop.
> 
> so what we need is to rename sk_busy_loop() into sk_busy_poll.
> 

Ok.

Thinking about it again, what is the point of your commit commit
89bf1b5a683df497c572c4d3bd3f9c9aa919d773 (net: remove NET_LL_RX_POLL
config menue)? After that commit, CONFIG_NET_LL_RX_POLL is not visible
by user and no other configs select it, also since it defaults to y, it
will be _always_ enabled. If this is really what you want, we can simply
remove all !CONFIG_NET_LL_RX_POLL code.