From: Aaron Brown <aaron.f.brown@intel•com>
To: Florian Fainelli <f.fainelli@gmail•com>
Cc: netdev@vger•kernel.org, e1000-devel@lists•sourceforge.net,
alexander.h.duyck@intel•com, jesse.brandeburg@intel•com
Subject: Re: [PATCH net-next] ixgbevf: fix skb->pkt_type checks
Date: Thu, 27 Feb 2014 14:58:46 -0800 [thread overview]
Message-ID: <1393541926.1931.4.camel@localhost> (raw)
In-Reply-To: <1393454640-19651-1-git-send-email-f.fainelli@gmail.com>
On Wed, 2014-02-26 at 14:44 -0800, Florian Fainelli wrote:
> skb->pkt_type is not a bitmask, but contains only value at a time from
> the range defined in include/uapi/linux/if_packet.h.
>
> Checking it like if it was a bitmask of values would also cause
> PACKET_OTHERHOST, PACKET_LOOPBACK and PACKET_FASTROUTE to be matched by this
> check since their lower 2 bits are also set, although that does not fix a real
> bug due to how the checks are used, it is still potentially confusing.
>
> This bogus check was introduced in commit 815cccbf ("ixgbe: add setlink,
> getlink support to ixgbe and ixgbevf").
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail•com>
> ---
> drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Thanks Florian, I have added this to our internal queue.
next prev parent reply other threads:[~2014-02-27 22:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-26 22:44 [PATCH net-next] ixgbevf: fix skb->pkt_type checks Florian Fainelli
2014-02-27 21:07 ` David Miller
2014-02-27 22:39 ` Skidmore, Donald C
2014-02-27 22:58 ` Aaron Brown [this message]
2014-02-28 23:26 ` Brown, Aaron F
2014-02-28 23:31 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1393541926.1931.4.camel@localhost \
--to=aaron.f.brown@intel$(echo .)com \
--cc=alexander.h.duyck@intel$(echo .)com \
--cc=e1000-devel@lists$(echo .)sourceforge.net \
--cc=f.fainelli@gmail$(echo .)com \
--cc=jesse.brandeburg@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox