Subject: Re: [PATCH net-next] icmp6: Add new icmpv6 type for RPL control message

From: Hannes Frederic Sowa <[email-masked]>
Date: Tue, 07 Oct 2014 22:26:30 +0200

On Di, 2014-10-07 at 15:55 -0400, David Miller wrote:
> From: Hannes Frederic Sowa <[email-masked]>
> Date: Tue, 07 Oct 2014 01:53:46 +0200
> 
> > Might be possible, but I would favor to get rid of the printk or move
> > the test for informational icmp notifications up.
> > Some of the type < 128 icmp (non-informal) packets we also report to
> > user space, so we cannot just add them to a blacklist.
> 
> So basically:
> 
> diff --git a/net/ipv6/icmp.c b/net/ipv6/icmp.c
> index 141e1f3..97ae700 100644
> --- a/net/ipv6/icmp.c
> +++ b/net/ipv6/icmp.c
> @@ -777,12 +777,12 @@ static int icmpv6_rcv(struct sk_buff *skb)
>  		break;
>  
>  	default:
> -		LIMIT_NETDEBUG(KERN_DEBUG "icmpv6: msg of unknown type\n");
> -
>  		/* informational */
>  		if (type & ICMPV6_INFOMSG_MASK)
>  			break;
>  
> +		LIMIT_NETDEBUG(KERN_DEBUG "icmpv6: msg of unknown type\n");
> +
>  		/*
>  		 * error of unknown type.
>  		 * must pass to upper level

Yep, can you take care of this?

Acked-by: Hannes Frederic Sowa <[email-masked]>

Thanks! :)