From: Joe Perches <realty@perches•com>
To: netdev <netdev@vger•kernel.org>
Subject: Convert net_msg_warn, NETDEBUG, & LIMIT_NETDEBUG?
Date: Tue, 04 Nov 2014 12:46:40 -0800 [thread overview]
Message-ID: <1415134000.23168.7.camel@perches.com> (raw)
net_msg_warn is a sysctl used to control the printk
of a bundle of mostly ipv4/ipv6 logging messages.
Does anyone use it?
NETDEBUG is used 4 times, 2 of which seem senseless
as they are allocation failures messages after an
alloc_skb. These already get stack dumps.
The other NETDEBUG uses are ESP crypto descriptions.
LIMIT_NETDEBUG is used a lot more.
include/net/sock.h:#define LIMIT_NETDEBUG(fmt, args...) \
include/net/sock.h- do { if (net_msg_warn && net_ratelimit()) printk(fmt,##args); } while(0)
Most of the LIMIT_NETDEBUG uses are emitted at KERN_DEBUG.
Here is the count of each type of use:
31 KERN_DEBUG
2 KERN_ERR
3 KERN_INFO
11 KERN_WARNING
Should those KERN_DEBUG uses be converted to
net_dbg_ratelimited so that these uses could be
controlled via dynamic_debug instead of the
net_msg_warn sysctl?
net/dccp/ uses LIMIT_NETDEBUG via DCCP_WARN to
control another 38 KERN_WARNING messages.
The others LIMIT_NETDEBUG uses could be converted
to net_<level>_ratelimited if appropriate.
next reply other threads:[~2014-11-04 20:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-04 20:46 Joe Perches [this message]
2014-11-05 22:16 ` Convert net_msg_warn, NETDEBUG, & LIMIT_NETDEBUG? David Miller
2014-11-05 22:39 ` [PATCH net-next] net; ipv[46] - Remove 2 unnecessary NETDEBUG OOM messages Joe Perches
2014-11-06 20:11 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415134000.23168.7.camel@perches.com \
--to=realty@perches$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox