Subject: Re: [PATCH 1/1] linux-wireless: Added psk in struct cfg80211_connect_params needed for offloading 4way handshake to driver

From: Johannes Berg <[email-masked]>
Date: Tue, 11 Nov 2014 11:38:58 +0100

On Tue, 2014-11-11 at 11:35 +0100, Arend van Spriel wrote:

> What did pop up is the wiphy flags vs. nl80211 feature flags. When that
> comes up it looks like 'potAtoes, potaetoes' to me.
> 
> So is there are clear design rule for when to use which flag. For me the
> wiphy object represents the device/firmware and 4-way handshake offload
> support is determined by what the device/firmware supports.

There are three types of flags:

 * wiphy flag attributes - deprecated as far as I'm concerned
 * wiphy nl80211 feature flags - much easier to use in kernel (and
userspace)
 * nl80211 protocol flags - only one exists
                            (NL80211_PROTOCOL_FEATURE_SPLIT_WIPHY_DUMP)

johannes