Subject: Re: [PATCH net] packet: bail out of packet_snd() if L2 header creation fails

From: Joe Perches <[email-masked]>
Date: Sun, 11 Jan 2015 10:52:25 -0800

On Sun, 2015-01-11 at 13:01 -0500, Christoph Jaeger wrote:
> Due to a misplaced parenthesis, the expression
> 
>   (unlikely(offset) < 0),
> 
> which expands to
> 
>   (__builtin_expect(!!(offset), 0) < 0),

Here's another one:

drivers/platform/goldfish/goldfish_pipe.c:285:	if (unlikely(bufflen) == 0)